Skip to content

[CYP-97] Fix for bug in zipping directory #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 21, 2020
Merged

[CYP-97] Fix for bug in zipping directory #12

merged 5 commits into from
Apr 21, 2020

Conversation

SagarGaniga
Copy link
Collaborator

@SagarGaniga SagarGaniga commented Apr 20, 2020 •
edited
Loading

This PR fixes

  1. Circular zipping issue when browserstack.js is in the same folder as cypress.json. I used directory() before which does not allow filtering, now using glob to select only allowed file extensions.
  2. Whitelisting of the allowed file extension and adds the node_modules folder to ignore list
  3. Deleting zip file in case of upload failure or zipping failure
  4. Remove validation of file extension before zipping as it is handled during the zip creation now.

nagpalkaran95
nagpalkaran95 previously approved these changes Apr 20, 2020
View reviewed changes
@SagarGaniga SagarGaniga changed the title [CYP-97] FIx for bug in zipping directory [CYP-97] Fix for bug in zipping directory Apr 20, 2020
@suryart suryart merged commit dce5caa into master Apr 21, 2020
@suryart suryart deleted the CYP_97_bug_in_zipping_directory branch April 21, 2020 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suryart suryart suryart approved these changes

@nagpalkaran95 nagpalkaran95 nagpalkaran95 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SagarGaniga @suryart @nagpalkaran95